[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

Luboš Luňák via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 21 08:28:40 PDT 2020


llunak added a comment.

So what more needs to be done here to get this change accepted? It's already missed 10.0 and 11.1 is getting branched off in about 3 weeks.

- The change was already accepted once and the problem leading to its revert has already been fixed.
- It just enables for PCH something that's been enabled for modules for a long time (so whatever may be wrong with it will probably be wrong with modules as well).
- I've been using the feature for 8 months.
- There's no publicly reported problem with it (I know aganea reported them above, but they are private, so nobody can do anything about them).
- The feature is opt-in and disabled by default.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69778/new/

https://reviews.llvm.org/D69778





More information about the cfe-commits mailing list