[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 18 09:13:26 PDT 2020


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65
+                        "-shared",
+                        "-mllvm",
+                        "-amdgpu-internalize-symbols",
+                        "-o",
----------------
arsenm wrote:
> We should probably add an lld driver flag for this rather than relying on the backend option? Is there some regular way to specify internalization that could add the target pass instead?
the current approach should work. I will do restructuring later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81959/new/

https://reviews.llvm.org/D81959





More information about the cfe-commits mailing list