[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 18 07:34:56 PDT 2020


NoQ added inline comments.


================
Comment at: clang/utils/analyzer/Dockerfile:15
+# test system dependencies
+RUN apt-get update && apt-get install -y \
+    git \
----------------
NoQ wrote:
> Maybe put `apt-get update` on a separate line?
> 
> Also i think you mentioned offline that you want to freeze package versions here, can you add a FIXME?
> can you add a FIXME?

Wait, you already did that in D81600, nvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81571/new/

https://reviews.llvm.org/D81571





More information about the cfe-commits mailing list