[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 18 01:35:58 PDT 2020


njames93 added a comment.

I'm of the idea that rather than having `ClangdTidyOptionsProvider` inherit form `tidy::ClangTidyOptionsProvider`, just have it as its own class. We don't need the interface offered by clang tidy here. It would solve the `must be threadsafe` comment issue as well as reduce the need for some unnecessary code in there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82002/new/

https://reviews.llvm.org/D82002





More information about the cfe-commits mailing list