[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

Endre Fülöp via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 17 02:40:08 PDT 2020


gamesh411 added a comment.

Minor nits inline. Good job, I am not entitled to accept it, but LGTM!



================
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.h:23
+/// Finds ``signal`` function calls when the program is multithreaded. It
+/// founds a program multithreaded when it finds at least one function call
+/// of the following: ``thrd_create``, ``std::thread``, ``boost::thread``,
----------------
gamesh411 wrote:
> founds -> finds, but I would rather reword it like this:
> The checker considers the analyzed program multithreaded if it finds ....
Or better:
The **check** considers ...
as the term `checker` is used more in ClangSA, and `check` in clang-tidy.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75229/new/

https://reviews.llvm.org/D75229





More information about the cfe-commits mailing list