[clang] e00dcf6 - NFC: cleanup the "(void)" case trick since the assertion is wrapped in NDEBUG.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 16 00:46:42 PDT 2020


Author: Haojian Wu
Date: 2020-06-16T09:46:29+02:00
New Revision: e00dcf61a2f4397c0525db7133503b80d8ecf5ac

URL: https://github.com/llvm/llvm-project/commit/e00dcf61a2f4397c0525db7133503b80d8ecf5ac
DIFF: https://github.com/llvm/llvm-project/commit/e00dcf61a2f4397c0525db7133503b80d8ecf5ac.diff

LOG: NFC: cleanup the "(void)" case trick since the assertion is wrapped in NDEBUG.

Added: 
    

Modified: 
    clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp b/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
index 6d0e36355b4c..e690ed849e40 100644
--- a/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
+++ b/clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
@@ -273,7 +273,7 @@ CheckerRegistry::CheckerRegistry(
   resolveDependencies<true>();
   resolveDependencies<false>();
 
-#ifndef NDEBUG // avoid -Wunused warnings in release build.
+#ifndef NDEBUG
   for (auto &DepPair : Dependencies) {
     for (auto &WeakDepPair : WeakDependencies) {
       // Some assertions to enforce that strong dependencies are relations in
@@ -285,9 +285,7 @@ CheckerRegistry::CheckerRegistry(
              "A strong dependency mustn't have weak dependencies!");
       assert(WeakDepPair.second != DepPair.second &&
              "A strong dependency mustn't be a weak dependency as well!");
-      (void)WeakDepPair;
     }
-    (void)DepPair;
   }
 #endif
 


        


More information about the cfe-commits mailing list