[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 15 17:08:54 PDT 2020


ldionne added a comment.

While this doesn't look wrong to me -- and the correctness of this depends entirely on where vendors decide to put their headers so it's hard for me to verify -- I'm wondering why not all toolchains use this mechanism. We seem to be adding an abstraction that's used only by some toolchains, but not all. I think it would be great to have a single canonical way of representing the system root.

Commenting out of curiosity, don't let this block you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81622/new/

https://reviews.llvm.org/D81622





More information about the cfe-commits mailing list