[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 15 14:21:03 PDT 2020


jdoerfert added a comment.

Assuming this passes all the tests, it looks good to me. Let's wait a day or two for people to take a look though :)



================
Comment at: llvm/test/TableGen/directive.td:34
+// CHECK-NEXT: }
+// CHECK-NEXT: }
----------------
clementval wrote:
> jdoerfert wrote:
> > How does the `allowedClauses` affect the result?
> > 
> It does not affect the result in this case. It will be used in a next patch were with can replace the `isAllowedClauseForDirective` code generation with TableGen. 
Gotcha.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81736/new/

https://reviews.llvm.org/D81736





More information about the cfe-commits mailing list