[PATCH] D69764: [clang-format] Add East/West Const fixer capability

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 13 17:37:32 PDT 2020


steveire added a comment.

In D69764#2063798 <https://reviews.llvm.org/D69764#2063798>, @MyDeveloperDay wrote:

> @steveire Thanks for the additional test cases, I'm reworking how I handle the Macro case as I realized that I didn't actually even try to change the case @rsmith came up with in the first place. I made a decision previous that I couldn't handle any case without the *,& or && to determine that wasn't the case
>
> Just ignoring upper case isn't a good idea either because of LONG,HRESULT and LRESULT types.
>
> it may take me a couple of days, but I agree to have something akin to FOREACH macros might be the way to go.


I think I've found more bugs in the current implementation, but I think you're working on a totally different implementation now, so there may not be so much value in reporting bugs with the current implementation, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764





More information about the cfe-commits mailing list