[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 11 12:07:52 PDT 2020


rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

I think renaming the flag in the AST dump output would be a good idea, though it'll be a lot of churn in the tests. I would prefer that we continue to dump a marker only if the declaration is not unconditionally visible rather than reversing the sense of the flag in the dump output. Maybe we should dump the ModuleOwnershipKind in general, not only an indicator of whether it's Visible or something else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81392/new/

https://reviews.llvm.org/D81392





More information about the cfe-commits mailing list