[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 6 inline comments as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:738
+      vlog("Dropped diagnostic: {0}: {1}", LastDiag->File, LastDiag->Message);
+    LastDiag.reset();
+  });
----------------
hokein wrote:
> shall we also reset `LastDiagLoc`?
We can, but it's redundant (dead store) and seems a bit "loose".
The LastDiag* variables are only meaningful if LastDiag is set.
Added comments to LastDiagLoc and LastDiagOriginallyError for this.


================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:282
+    template <typename T>
+    struct Derived : [[T]] {};"
+  )cpp");
----------------
hokein wrote:
> nit: an extra `;` at the end.
(Rather extra `"`, right?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81351/new/

https://reviews.llvm.org/D81351