[PATCH] D81420: Fix size for _ExtInt types with builtins

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Linking compiler-rt is something that should be automatically happening.  It's possible that compiler-rt will have different maximum widths on different targets, though.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939
   "to a non-const integer (%0 invalid)">;
+def err_overflow_builtin_extint_size : Error<
+  "_ExtInt argument larger than 64-bits to overflow builtin requires runtime "
----------------
erichkeane wrote:
> Mentioning target-specific support here seems incorrect. @rjmccall I cannot think of a better wording, can you?
"overflow builtins do not support _ExtInt operands of more than %0 bits on this target"?  I don't think it's unreasonable to mention the target-specificness of it.   Hard-coding the number 64 in the diagnostic seems excessively targeted, though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81420/new/

https://reviews.llvm.org/D81420