[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

Sterling Augustine via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 14:25:17 PDT 2020


saugustine created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
saugustine added reviewers: jyknight, echristo.
saugustine added a comment.

For post-commit review.


ROCm.h had been getting the declarations for various data structures
by being #included next to them, rather than #includeing them itself.

This change fixes that by explicitly including the appropriate headers.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81432

Files:
  clang/lib/Driver/ToolChains/ROCm.h


Index: clang/lib/Driver/ToolChains/ROCm.h
===================================================================
--- clang/lib/Driver/ToolChains/ROCm.h
+++ clang/lib/Driver/ToolChains/ROCm.h
@@ -10,9 +10,14 @@
 #define LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ROCM_H
 
 #include "clang/Basic/Cuda.h"
+#include "clang/Basic/LLVM.h"
+#include "clang/Driver/Driver.h"
 #include "clang/Driver/Options.h"
 #include "llvm/ADT/SmallSet.h"
 #include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringMap.h"
+#include "llvm/ADT/Triple.h"
+#include "llvm/Option/ArgList.h"
 
 namespace clang {
 namespace driver {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81432.269356.patch
Type: text/x-patch
Size: 594 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200608/ef3b7ad7/attachment.bin>


More information about the cfe-commits mailing list