[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

Oliver Stannard (Linaro) via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 09:56:55 PDT 2020


ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.

LGTM, inline comment could be done as a follow-up patch given that this is time-sensitive (recently published security vulnerability).



================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:229
+      Scope.split(Opts, ",");
+      for (int I = 0, E = Opts.size(); I != E; ++I) {
+        StringRef Opt = Opts[I].trim();
----------------
Could this be a range-based for loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81404/new/

https://reviews.llvm.org/D81404





More information about the cfe-commits mailing list