[PATCH] D79842: [clang][Driver] Correct tool search path priority

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/program-path-priority.c:15
+// "program path" for these tests
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
----------------
`rm -rf %t && mkdir -p %t`
You can do this on one line


================
Comment at: clang/test/Driver/program-path-priority.c:17
+// RUN: mkdir -p %t
+// RUN: cp %clang %t
+
----------------
clang can be of several hundred bytes. Copying it is expensive. Use `ln -s` and add `UNSUPPORTED: system-windows` with a comment saying "Don't create symlinks on Windows" or similar


================
Comment at: clang/test/Driver/program-path-priority.c:19
+
+// No gccs at all, nothing is found
+// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \
----------------
You can use `/// ` to make comments stand out from RUN and CHECK lines.


================
Comment at: clang/test/Driver/program-path-priority.c:20
+// No gccs at all, nothing is found
+// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \
+// RUN: | FileCheck --check-prefix=NO_NOTREAL_GCC %s
----------------
Place `\` on the previous line to emphasize it has a continuation. Add two spaces before the continuation line to emphasize it is a continuation line.


================
Comment at: clang/test/Driver/program-path-priority.c:39
+// RUN: | FileCheck --check-prefix=ENV_PATH_NOTREAL_GCC %s
+// ENV_PATH_NOTREAL_GCC: env{{/|\\\\}}notreal-none-elf-gcc
+
----------------
Just use `/` since you are going to use `ln -s` `chmod +x` etc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79842/new/

https://reviews.llvm.org/D79842