[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 4 12:09:44 PDT 2020


vsk added a subscriber: phosek.
vsk added a comment.

In D81122#2074213 <https://reviews.llvm.org/D81122#2074213>, @keith wrote:

> FYI I actually removed that piece this morning since I felt like since this now supports `-path-equivalence=.,foo` which is the "expected" behavior from lldb, that was "good enough". lmk if you want me to add it back!


I missed the fact that there's already some discussion of working with remote builds in the command guide. I don't think it needs to be changed.

Separately, @phosek pointed out that there might be an issue with changing the way paths work in coverage mappings based on -fdebug-prefix-map or -fdebug-compilation-dir alone. Mind holding off on landing this until we pick some way to resolve the issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81122/new/

https://reviews.llvm.org/D81122





More information about the cfe-commits mailing list