[PATCH] D80979: [clang] Implement VectorType logic not operator.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746
+  if (E->getType()->isVectorType() &&
+      E->getType()->castAs<VectorType>()->getVectorKind() ==
+          VectorType::GenericVector) {
----------------
junparser wrote:
> erichkeane wrote:
> > Why limit this to just the base vector type?  Doesn't this remove the ext-vector implementation?
> > 
> > 
> the kind of ext-vector is  GenericVector as well. so it also includes ext-vector.
"isVectorType" also includes ExtVectorType.  My question is which vector types are you attempting to exclude here?

Can the ExtVectorKind ever be a AltiVec* or Neon Vector type?  If so, this change would break code for those.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80979/new/

https://reviews.llvm.org/D80979