[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

[Ten Tzen via Phabricator via cfe-commits]

tentzen marked 3 inline comments as done.
tentzen added a comment.

thank you David.  will update and submit a new patch shortly.



================
Comment at: clang/lib/CodeGen/CGException.cpp:603-609
+      // For IsEHa catch(...) must handle HW exception
+      // Adjective = HT_IsStdDotDot (0x40), only catch C++ exceptions
+      // Also mark scope with SehTryBegin
+      if (getLangOpts().EHAsynch) {
+        TypeInfo.Flags = 0;
+        EmitRuntimeCallOrInvoke(getSehTryBeginFn(CGM));
+      }
----------------
majnemer wrote:
> I think this logic should move into MicrosoftCXXABI::getCatchAllTypeInfo.
good point. thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344