[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

Wed Jun 3 08:12:23 PDT 2020

njames93 marked an inline comment as done.
njames93 added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:39
+    "__builtin_classify_type",
+    // "__builtin_va_start",
+    // "__builtin_stdarg_start",
----------------
aaron.ballman wrote:
> I think we may want to keep this one as it's the builtin for the `va_start` macro, which is not variadic.
Allowing `va_start` makes sense, but its breaking the current test cases. According to the documentation that is expected behaviour, So shall I remove `__builtin_va_start` again?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80887/new/

https://reviews.llvm.org/D80887