[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 15:56:28 PDT 2020


thakis added a comment.

The change description says something about PWD (which makes me worried about build determinism, like amccarth), but I don't see anything about that in the diff.

The diff as-is looks fine to me with hans's comment about duplication resolved in some form. Please don't add code that stores absolute paths, but at the moment this doesn't do that as far as I can tell :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80833/new/

https://reviews.llvm.org/D80833





More information about the cfe-commits mailing list