[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

Peter Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 14:16:07 PDT 2020


psmith accepted this revision.
psmith added a comment.

LGTM from an Arm person now that the Android changes have been made.



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22
 #include "InputInfo.h"
+#include "MSP430.h"
 #include "PS4CPU.h"
----------------
nickdesaulniers wrote:
> Note to reviewers: the linter really wanted to touch this header inclusion list, since I add "llvm/Support/Compiler.h" below.  Hopefully it's ok to just include with this patch?
One possible solution here is to commit the reordering separately using an [NFC] refactoring commit, no separate review required, then commit the rest of the patch after that. Anyone doing a source code search will only pick up significant changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80828/new/

https://reviews.llvm.org/D80828





More information about the cfe-commits mailing list