[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 07:41:42 PDT 2020


arsenm added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389
 
-  for (Arg *A : Args) {
-    DAL->append(A);
+  if (DeviceOffloadKind != Action::OFK_OpenMP) {
+    for (Arg *A : Args) {
----------------
Needs a comment? I don't understand why openmp is any different here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80996/new/

https://reviews.llvm.org/D80996





More information about the cfe-commits mailing list