[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen

Mikhail Maltsev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 06:36:34 PDT 2020


miyuki added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c:8
+// CHECK-LABEL: test_vbfdot_f32
+// CHECK:  %0 = bitcast <4 x bfloat> %a to <8 x i8>
+// CHECK:  %1 = bitcast <4 x bfloat> %b to <8 x i8>
----------------
Why not `CHECK-NEXT`?


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4
+; CHECK-LABEL: test_vbfdot_f32
+; CHECK: bfdot   v0.2s, v1.4h, v2.4h
+define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4 x bfloat> %a, <4 x bfloat> %b) {
----------------
Would it make sense to check the whole body of the compiled function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80752/new/

https://reviews.llvm.org/D80752





More information about the cfe-commits mailing list