[PATCH] D68049: Propeller: Clang options for basic block sections

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 1 11:53:03 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/ELF/LTO.cpp:79
   // Check if basic block sections must be used.
   // Allowed values for --lto-basicblock-sections are "all", "labels",
   // "<file name specifying basic block ids>", or none.  This is the equivalent
----------------
`--lto-basic-block-sections`

I think it should be fine updating it here, and probably preferable, since you already touched some related LLD code. It does not affect any tests. (You did not add any tests for `--lto-basicblock-sections` in the original LLD patch.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68049/new/

https://reviews.llvm.org/D68049





More information about the cfe-commits mailing list