[PATCH] D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 29 06:29:16 PDT 2020


mboehme updated this revision to Diff 267210.
mboehme added a comment.

When testing with the real libc++ and glibc, I realized that I was still getting a cyclic dependency between the two modules because the builtin stddef.h that glibc was including was still being ascribed to libc++.

This modified version fixes this and also updates the test to more closely reflect the real libc++ and glibc so that my previous version of the fix also fails with a cyclic dependency.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80781/new/

https://reviews.llvm.org/D80781

Files:
  clang/include/clang/Lex/ModuleMap.h
  clang/lib/Lex/HeaderSearch.cpp
  clang/lib/Lex/ModuleMap.cpp
  clang/test/Modules/Inputs/no-undeclared-includes-builtins/glibc/module.modulemap
  clang/test/Modules/Inputs/no-undeclared-includes-builtins/glibc/stdio.h
  clang/test/Modules/Inputs/no-undeclared-includes-builtins/libcxx/module.modulemap
  clang/test/Modules/Inputs/no-undeclared-includes-builtins/libcxx/stddef.h
  clang/test/Modules/Inputs/no-undeclared-includes-builtins/libcxx/stdio.h
  clang/test/Modules/no-undeclared-includes-builtins.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80781.267210.patch
Type: text/x-patch
Size: 6831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200529/7b0f524c/attachment-0001.bin>


More information about the cfe-commits mailing list