[PATCH] D78454: [clangd] Highlight related control flow.

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 08:15:09 PDT 2020


Added workaround in 6dd1629770d686831bdb2649650b86c37f0f7091 - will look at
disabling tests properly tomorrow.

On Thu, May 28, 2020 at 4:55 PM Sam McCall <sammccall at google.com> wrote:

> On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> russell.gallop added a comment.
>>
>> Hi Sam,
>>
>> It looks like this is causing a failure on the Windows PS4 buildbot:
>> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606
>>
>> Please could you take a look? PS4 target disables RTTI, hence exceptions,
>> by default so it is probably related to that.
>>
> Thanks!
> Hmm, the clangd tests are supposed to be disabled on PS4 for exactly these
> sorts of reasons. It looks like that's only working for shell tests, not
> gtests though.
> Lit config is a tangled mess... is there an #ifdef we can use to disable
> just that test on PS4 until I get this sorted out?
>
>
>>
>> Thanks
>> Russ
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D78454/new/
>>
>> https://reviews.llvm.org/D78454
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200528/86e6936b/attachment-0001.html>


More information about the cfe-commits mailing list