[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

Marco Elver via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 27 15:16:36 PDT 2020


melver created this revision.
melver added a reviewer: vitalybuka.
Herald added subscribers: cfe-commits, danielkiss, kristof.beyls.
Herald added a project: clang.
melver added a comment.

Example of failing test:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/10689

So this definitely can't be -target, because we set that. So it seems that some version of LLVM compiled for armv7 is somehow broken?

Vitaly, I wasn't able to test this since I don't have access to any such platform right now. If the "XFAIL" looks sane, and there isn't a better option, the build bots should eventually be able to tell us if this is reasonable.

Thanks!


Versions of LLVM built on {arm,thumb}v7 appear to have differently
configured pass managers, which causes restrictions on which sanitizers
we may use.

As such, expect failure of the recently added "sanitize-coverage.c" test
on these architectures until we can investigate armv7's restrictions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80668

Files:
  clang/test/CodeGen/sanitize-coverage.c


Index: clang/test/CodeGen/sanitize-coverage.c
===================================================================
--- clang/test/CodeGen/sanitize-coverage.c
+++ clang/test/CodeGen/sanitize-coverage.c
@@ -4,6 +4,8 @@
 // RUN: %clang %s -target x86_64-unknown-linux-gnu -emit-llvm -S -fsanitize=memory     -fsanitize-coverage=trace-pc,trace-cmp -o - | FileCheck %s --check-prefixes=CHECK,MSAN
 // RUN: %clang %s -target x86_64-unknown-linux-gnu -emit-llvm -S -fsanitize=thread     -fsanitize-coverage=trace-pc,trace-cmp -o - | FileCheck %s --check-prefixes=CHECK,TSAN
 // RUN: %clang %s -target x86_64-unknown-linux-gnu -emit-llvm -S -fsanitize=undefined  -fsanitize-coverage=trace-pc,trace-cmp -o - | FileCheck %s --check-prefixes=CHECK,UBSAN
+//
+// XFAIL: armv7, thumbv7
 
 int x[10];
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80668.266681.patch
Type: text/x-patch
Size: 788 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200527/4a815c0a/attachment.bin>


More information about the cfe-commits mailing list