[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Francois Ferrand via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 13:05:35 PDT 2020


Typz added a comment.

In D50078#2055227 <https://reviews.llvm.org/D50078#2055227>, @srj wrote:

> > And I also think it should be on by default instead of modifying many .clang-format files. So IMHO if we add an option, it should be opt-out.
>
> I can live with it being opt-out. My big concern is that (as it currently stands) our project gets different 'canonical' clang-format results depending on whether people are using LLVM10 vs LLVM11 (and both are common and supported by our project), which is a headache. I just want a way to get consistent, predictable formatting regardless of the clang-format version.


Adding an option would be an issue there, I think: since clang-format is quite strict regarding options, the option would need to exist in both LLVM10 and LLVM11 if you need to support such use-case...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50078/new/

https://reviews.llvm.org/D50078





More information about the cfe-commits mailing list