[PATCH] D79842: [clang][Driver] Correct tool search path priority

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 21 14:05:38 PDT 2020


nickdesaulniers added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4730
+          return std::string(P.str());
+      }
     } else {
----------------
style nit: are the `{}` on the `for` necessary?


================
Comment at: clang/test/Driver/program-path-priority.c:3
+// Names and locations are usually in this order:
+// <triple>-tool, tool, <defaul triple>-tool
+// program path, PATH
----------------
s/defaul/default/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79842/new/

https://reviews.llvm.org/D79842





More information about the cfe-commits mailing list