[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 21 10:49:34 PDT 2020


tra added inline comments.


================
Comment at: clang/include/clang/Basic/TargetInfo.h:1418
+  /// Whether floating point atomic fetch add/sub is supported.
+  virtual bool isFPAtomicFetchAddSubSupported() const { return false; }
+
----------------
I think it should be predicated on specific type.
E.g. NVPTX supports atomic ops on fp32 ~everywhere, but fp64 atomic add/sub is only supported on newer GPUs.
And then there's fp16...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71726/new/

https://reviews.llvm.org/D71726





More information about the cfe-commits mailing list