[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 21 06:59:06 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:452
       CmdArgs.push_back("-dynamic-linker");
-      CmdArgs.push_back(Args.MakeArgString(Loader));
+      CmdArgs.push_back(Args.MakeArgString(Twine(D.DyldPrefix) +
+                                           ToolChain.getDynamicLinker(Args)));
----------------
nemanjai wrote:
> Is this just an orthogonal NFC change? If so, can you please commit it separately in an NFC commit?
Yes; all of the other changes made around here disappeared during the development process. Would it be okay to split it out on the commit instead of updating the patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80300/new/

https://reviews.llvm.org/D80300





More information about the cfe-commits mailing list