[PATCH] D79595: Fix bugs when an included file name is typo corrected.

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Mon May 18 11:25:13 PDT 2020


+thakis who I think fell off the cc list

On Thu, May 14, 2020 at 12:51 AM Abhinav Gaba via Phabricator
<reviews at reviews.llvm.org> wrote:
>
> abhinavgaba added inline comments.
>
>
> ================
> Comment at: clang/test/Lexer/case-insensitive-include-win.c:8
>  // RUN: touch %t.dir/foo.h
> -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s
> +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -fsyntax-only %s 2>&1 | FileCheck %s
>
> ----------------
> abhinavgaba wrote:
> > The test is currently failing if path of an existing directory in a network mounted drive, using forward slashes, is in CPATH. (e.g. `export CPATH=//abc.def.com/dir1`).
> >
> > The error in that case is:
> > ```
> > fatal error: cannot open file
> >       '//abc.def.com/dir1\?\<path_to_clang_dir>\test\Lexer\Output\case-insensitive-include-win.c.tmp.dir\FOO.h':
> >       The specified path is invalid.
> > ```
> >
> Did you get a chance to look at this?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79595/new/
>
> https://reviews.llvm.org/D79595
>
>
>


More information about the cfe-commits mailing list