[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 18 09:07:38 PDT 2020


NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:462
+    if (CoversTheWholeType) {
+      return {ValueFactory.getMinValue(RangeType),
+              ValueFactory.getMaxValue(RangeType)};
----------------
vsavchenko wrote:
> NoQ wrote:
> > You mean zero, right?
> No, not always.  It still can be signed at this point.
Ok, so i misunderstood. This function computes range of `abs($x)` aka `|$x|` given the range for `$x`, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80117/new/

https://reviews.llvm.org/D80117





More information about the cfe-commits mailing list