[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 18 08:01:54 PDT 2020


sepavloff updated this revision to Diff 264623.
sepavloff added a comment.

Updated patch

Default lowering of FLT_ROUNDS_ again is made by replacing the node with
constant 1, which denotes rounding to nearest, ties to even. It is incorrect,
but is compatible with with current behavior. Using more correct lowering to
function call may cause problems for targents that rely on default lowering,
because not all C standard libraries implements `__flt_rounds`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79322/new/

https://reviews.llvm.org/D79322

Files:
  clang/include/clang/Basic/Builtins.def
  llvm/docs/LangRef.rst
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/RuntimeLibcalls.def
  llvm/lib/CodeGen/IntrinsicLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79322.264623.patch
Type: text/x-patch
Size: 4349 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200518/2d3ca6e5/attachment.bin>


More information about the cfe-commits mailing list