[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 17 03:43:39 PDT 2020


steveire added a comment.

In D72530#2038561 <https://reviews.llvm.org/D72530#2038561>, @aaron.ballman wrote:

> The changes here look reasonable, but can some of this code be simplified to use the default behavior and less complex matchers that don't have to carefully ignore implicit nodes? This would demonstrate that the feature really is an improvement over the status quo and would also exercise more test code with the new defaults demonstrating equivalence. I'm not envisioning anything onerous, more just wondering if you think there is some low-hanging fruit that could be picked rather than converting everything to AsIs.


After changing the default there will be opportunities for that as a follow-up, yes. But this patch is ordered before changing the default. The change you describe is a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72530/new/

https://reviews.llvm.org/D72530





More information about the cfe-commits mailing list