[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 12 14:32:45 PDT 2020


dblaikie requested changes to this revision.
dblaikie added a comment.
This revision now requires changes to proceed.

So the original commit ( cbc9d22e49b4 <https://reviews.llvm.org/rGcbc9d22e49b434b6ceb2eb94b67079d02e0a7b74> ) was reverted at some point, and now you're proposing recommitting it with a slight change?

Could you summarize (in the summary (which should hopefully be included in the commit message eventually)) the commit (include the hash), the revert (including the hash), reasons for revert and what's changed in this patch compared to the original commit that addresses the reasons for reverting? (& ideally what extra testing was done on the newer version of the patch to ensure the original issue or another like it would now be caught before committing)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69778/new/

https://reviews.llvm.org/D69778





More information about the cfe-commits mailing list