[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

Could you also put `Fixes https://github.com/clangd/clangd/issues/375` in the commit message?



================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:381
       int i = 3;
       double f = [[8]] / i;  // NOLINT // error-ok
     }
----------------
you can also drop the `// error-ok` now as there are no diags left.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79691/new/

https://reviews.llvm.org/D79691