[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 11 10:45:34 PDT 2020


rjmccall added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3185
   Opts.FiniteMathOnly = Args.hasArg(OPT_ffinite_math_only) ||
       Args.hasArg(OPT_cl_finite_math_only) ||
       Args.hasArg(OPT_cl_fast_relaxed_math);
----------------
mibintc wrote:
> @rjmccall @plotfi These earlier patches are also deriving the value of LangOpts from the settings of CG opts
I don't know what you mean here; the code you're quoting just seems to be looking at `Args`.  It's fine to re-parse arguments in both places if that makes something easier.  The problem is that you're looking at the CodeGenOptions structure itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841





More information about the cfe-commits mailing list