[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/Protocol.cpp:569
+    Result["version"] = PDP.version;
+  // FIXME: workaround for older gcc/clang
+  return std::move(Result);
----------------
nit: I'm not sure it's actually worth having these comments everywhere. The move is harmless apart from readability, and the readability of drawing attention to them seems worse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79692/new/

https://reviews.llvm.org/D79692