[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 10 10:38:27 PDT 2020


njames93 added a comment.

In D79477#2028618 <https://reviews.llvm.org/D79477#2028618>, @hyd-dev wrote:

> > Not a fan of this test case as it only demonstrates the color behaviour of the process running the check not the actual option itself
>
> What does "option itself" mean?


What I mean to say is, if the behaviour of the testing environment changes to pipe the result to a terminal that supports color, it could cause this test case to also fail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79477/new/

https://reviews.llvm.org/D79477





More information about the cfe-commits mailing list