[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Zarko Todorovski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 8 12:20:25 PDT 2020


ZarkoCA added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5244
                                                 llvm::Value *Address) const {
-
-  return PPC64_initDwarfEHRegSizeTable(CGF, Address);
+  return PPC_initDwarfEHRegSizeTable(CGF, Address, /* Is64Bit*/ true,
+                                     /*IsAIX*/ false);
----------------
Missed to point out the extra space in `/* Is64Bit*/` previously. 


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4541
                                options::OPT_msvr4_struct_return)) {
-    if (TC.getArch() != llvm::Triple::ppc) {
+    // TODO: We might want to consider enable these two options on AIX in the
+    // future.
----------------
s/enable/enabling/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79035/new/

https://reviews.llvm.org/D79035





More information about the cfe-commits mailing list