[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 8 03:11:15 PDT 2020


balazske added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:481
+  ProgramStateRef State = C.getState();
+  if (isa<AnyFunctionCall>(Call) || isa<BlockCall>(Call)) {
+
----------------
The one thing where I am not sure is if this condition is really needed for every case (for example can `checkFunctionPointerCall` be moved outside this `if`?). I see only that `checkParameterCount` has to be in this `if` block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77846/new/

https://reviews.llvm.org/D77846





More information about the cfe-commits mailing list