[PATCH] D79480: [SveEmitter] Add builtins for SVE2 Polynomial arithmetic

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 7 03:55:12 PDT 2020


sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7813
+  llvm::ScalableVectorType *Ty = getSVEType(TypeFlags);
+  return Builder.CreateBitCast(Call, Ty);
+}
----------------
efriedma wrote:
> Please add a FIXME for big-endian. :)
Ah yes good spot. I've moved this (and the other use of bitcast for svreinterpret) to a separate function `EmitSVEReinterpret`, that has the FIXME. That way we only need to fix it in one place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79480/new/

https://reviews.llvm.org/D79480





More information about the cfe-commits mailing list