[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 6 03:11:50 PDT 2020


xazax.hun added a comment.

In D78933#2022288 <https://reviews.llvm.org/D78933#2022288>, @ASDenysPetrov wrote:

> Guys,
>  @xazax.hun, @Charusso, @steakhal, @vsavchenko, @NoQ, @baloghadamsoftware,
>  please, tell something. What do you think of this improvement?


Sorry, I will definitely take a look at this later today! In the meantime, we are always curious about the performance and usability implications of those patches.
Did you do some measurements on some projects how the run-time changes?
Also, it would be useful to see how statistics like coverage patterns, number of exploded nodes etc changes. See the output of `-analyzer-stats` option for details.



================
Comment at: clang/test/Analysis/constraint_manager_conditions.cpp:184
+}
\ No newline at end of file

----------------
Nit: please add new line at the end of the file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78933/new/

https://reviews.llvm.org/D78933





More information about the cfe-commits mailing list