[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:719
+         !getContext().getTargetInfo().hasInt128Type()))
+      return getNaturalAlignIndirect(Ty);
+
----------------
erichkeane wrote:
> rjmccall wrote:
> > It's very weird for 64 and 128 to be showing up as constants in the default ABI rule.
> Good point.  I rewrote this in terms of the Context.LongLongTy and Context.Int128Ty.
Maybe:

```
if (EIT->getNumBits() > Context.getTypeSize(Context.getTargetInfo().hasInt128Type() ? Context.Int128Ty : Context.LongLongTy)))
```


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:741
+         !getContext().getTargetInfo().hasInt128Type()))
+      return getNaturalAlignIndirect(RetTy);
+
----------------
Same rule needed here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79118/new/

https://reviews.llvm.org/D79118