[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 4 15:05:30 PDT 2020


tra added a comment.

In D79344#2018693 <https://reviews.llvm.org/D79344#2018693>, @hliao wrote:

> OK, I will add one option, But, do we turn it on by default or off?


As a rule of thumb, if it's an experimental feature, then the default would be off. For a change which should be the default, but is risky, the default is on. This patch looks like the latter.

If you can wait, I can try patching this change into our clang tree and then see if it breaks anything obvious. If nothing falls apart, I'll be fine with the patch as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79344/new/

https://reviews.llvm.org/D79344





More information about the cfe-commits mailing list