[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

Austin Kerbow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 4 15:05:27 PDT 2020


kerbowa added a comment.

In D79213#2018820 <https://reviews.llvm.org/D79213#2018820>, @hliao wrote:

> Any more comments? As this should be a performance-critical issue, shall we get conclusion and make progress for the next step?


We applied this current version of the patch internally for testing which is the reason for the lack of urgency, but hopefully we can get the final generic solution submitted upstream early this week. I believe I understand your comments and it makes sense to me that it should be safe for pointers whose coerced type is also a single pointer to retain the same attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79213/new/

https://reviews.llvm.org/D79213





More information about the cfe-commits mailing list