[PATCH] D79302: [clangd] Propogate context in LSPServer tests

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 3 11:09:33 PDT 2020


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp:164
+    WithContextValue Ctx(
+        llvm::make_scope_exit([&CallFinished] { CallFinished.notify(); }));
+    llvm::consumeError(Client.call(MethodName, {}).take().takeError());
----------------
Sorry, I didn't really put all the pieces together in my head the first time around.
The context propagation seems OK, but it's too fiddly as a way to control sequencing - can't you just call Client.sync() and assert after that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79302/new/

https://reviews.llvm.org/D79302





More information about the cfe-commits mailing list