[PATCH] D79302: [clangd] Propogate context in LSPServer tests

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 3 06:22:44 PDT 2020


kadircet marked 3 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120
+      auto Req = std::move(Requests.front());
+      // Leave request on the queue so that waiters can see it.
       Lock.unlock();
----------------
sammccall wrote:
> which waiters? isn't it just this thread?
i was envisioning the future(thought this already had a `blockUntilIdle` :D)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79302/new/

https://reviews.llvm.org/D79302





More information about the cfe-commits mailing list