[PATCH] D79290: Update suffix check and cast non-suffix types

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 2 10:03:27 PDT 2020


hubert.reinterpretcast added a comment.

In D79290#2016278 <https://reviews.llvm.org/D79290#2016278>, @reikdas wrote:

> In D79290#2016273 <https://reviews.llvm.org/D79290#2016273>, @hubert.reinterpretcast wrote:
>
> > @reikdas, please upload the full copy of your combined changes to D77598 <https://reviews.llvm.org/D77598> where the review is still active and close this.
>
>
> I am unable to add a diff/edit the old diff in the other revision(I think since I am not the author of that review). Clicking on "Update Diff" only allowed me to create a new revision.


Have you consulted with the author on the status of the other revision? The "Commandeer Revision" option under "Add Action" in the menu above the comment submission box might work from the technical side.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79290/new/

https://reviews.llvm.org/D79290





More information about the cfe-commits mailing list